rainbow icon indicating copy to clipboard operation
rainbow copied to clipboard

feat: intial cross chain swaps

Open estebanmino opened this issue 3 years ago • 3 comments

Fixes TEAM2-479, TEAM2-478, TEAM2-477, , TEAM2-481, TEAM2-453 Figma link (if any):

This PR enables cross chain swaps ⚔️

What changed (plus any additional context for devs)

  • tickets added to this PR to include sdk work

  • swapSheetFlow.spec e2e testing different network changes and checking that new components as the network switcher and the available network component on expanded state are only available when the feature flag is on

  • hardhatTransactionFlow.spec e2e to send a crosschain swap, mainnet DAI to optimism USDC

  • Patch added to swaps sdk to point it to a staging endpoint until we go live to production

Screen recordings / screenshots

What to test

https://www.loom.com/share/328873ac4c4f42edbfa65de3153b89dd

Final checklist

  • [x] Assigned individual reviewers?
  • [x] Added labels? (team1/team2, critical path, release, dev QA)
  • [x] Did you test both iOS and Android?
  • [ ] If your changes are visual, did you check both the light and dark themes?
  • [x] Added e2e tests? If not, please specify why
  • [ ] If you added new critical path files, did you update the CODEOWNERS file?
  • [ ] If no dev QA label, did you add the PR to the QA Queue?

estebanmino avatar Sep 15 '22 23:09 estebanmino

TEAM2-481 Transactions: Update redux swap `SwapState`

TBD according to values from SDK

linear[bot] avatar Sep 16 '22 00:09 linear[bot]

TEAM2-453 Errors: No route found

https://www.figma.com/file/SFfYzRoHlapEecS0LTLwhQ/Swap-Aggregator-V2?node-id=761%3A47140

image.png

  • New button state "No route found"
  • New no route found explainer

we need to add another error code coming from backend for this error

linear[bot] avatar Sep 16 '22 14:09 linear[bot]

android e2e passing with last commit

  • e2e/hardhatTransactionFlowSwaps.spec.js
  • e2e/swapSheetFlow2.spec.js

estebanmino avatar Sep 26 '22 23:09 estebanmino

/rebase

sammdec avatar Sep 27 '22 15:09 sammdec

Okay, I ran through the following:

mainnet eth -> mainnet usdc: This looked normal to me. https://recordit.co/NFfilCQWz0

mainnet eth -> arbitrum dai: Swap went through, didn't see a balance update. Balance updates seemed to be delayed on prod as well, though. https://recordit.co/mNQOK0Djhw

mainnet eth -> optimism eth: Same issue with L2 balance update. https://recordit.co/01mPvw0SQ3

mainnet eth -> polygon wbtc: Same issue with L2 balance update. https://recordit.co/SjgTHUtAmL

Issue found: The flip button seems broken when flipping assets that sit on the same chain. Crosschain flipping seems to work fine for some reason. https://recordit.co/PtBpoATz6H https://recordit.co/d7STd3Hijq

derHowie avatar Sep 27 '22 20:09 derHowie

thank you for the videos @derHowie ! fixed the issue on the last commit

estebanmino avatar Sep 27 '22 21:09 estebanmino

/testflight

ibrahimtaveras00 avatar Sep 27 '22 21:09 ibrahimtaveras00