Dave Enyeart comments

Results 249 comments of


                                            Dave Enyeart

WIP: prepare for etcd version bump.

@guoger Reminder... > @guoger etcd was updated in #2997 , anything else needed for this?

Initial purge private data integration tests

I don't think there is any reason to change go.mod or vendor directory in this PR.

Refactor Developing Applications documentation

@DARK-art108 Yes, please coordinate with @bestbeforetoday (aka Mark Lewis, aka bestbeforetoday) on the proposed approach. Mark is the application SDK lead and should be involved in Developing Applications changes.

Refactor Developing Applications documentation

Developing Applications doc has been removed. Intent now is to add some of the main concepts to the Key Concepts and Tutorial topics.

Support docker registry authentication when pulling chaincode builder images and chaincode runtime images

What do you think @mbwhite ?

[feature]peer lifecycle chaincode package support external chaincode

What do you think @mbwhite ?

Update test_network.md

Thanks for the update. We can merge this one, but I think ultimately we should remove the version reference in this doc and simply point to the main install doc...

Update test_network.md

No response from PR creator, closing...

checkcommitreadiness return always false for approvals

I'm not able to reproduce, it works for me. `--init-required` must either be absent or present in both the approveformyorg and checkcommitreadiness calls. In the example above it is present...

Update ordererchecklist.md

Thank you for the fix. You'll need to sign the commit, for instructions see https://github.com/hyperledger/fabric/pull/3282/checks?check_run_id=5526044566.