Support docker registry authentication when pulling chaincode builder images and chaincode runtime images

[Alex-duzhichao]

When deploying fabric in enterprise's intranet (without the ability to access internet), users maybe upload chaincode builder images and chaincode runtime images to a private docker registry which requires authentication when pulling images. I think fabric can support this scenario by adding configuration in chaincode section of core.yaml, such as:

chaincode:
    registry:
        authentication:
              user: ****
              password: ****

and then uses this configuration for authentication when invoking docker's api .

[denyeart]

What do you think @mbwhite ?

[mbwhite]

I can see that could be a useful addition certainly; we can currently configure what the chaincode builder images are, and that could quite easily be a private repo.

I'd suggest that we mark this as an Good First Issue, and ask for community contributions.

If possible,use the 'as-a-service' pattern for chaincode as this avoids these type of issues :-) Of course, might not be applicable in all cases.

[arsulegai]

@mbwhite are there thoughts around deprecating the chaincode build service via the peer node? (i.e. making chaincode as a service a default option)

[mbwhite]

@arsulegai Exactly.

[arsulegai]

This feature request would then be void. Would you still recommend somebody spending time on this feature?

[mbwhite]

honestly I wouldn't no.

[arsulegai]

Thanks for the heads up.

On side notes: I had a first time contributor interested in Fabric, they found this issue to work on based on the issue tag. Do you have anything else for them to pick up?

[AyushRaj8271]

Hey @arsulegai and @mbwhite is this issue still available for resolving?

[musinit]

Hi! @mbwhite can you tell please, is it still needs resolving?

[mbwhite]

Hello @musinit .. I don't believe that this needs resolving - the preferred solution would be the external chaincode-as-a-service feature.

[musinit]

Maybe we will close this issue? I want to start coding on some 'good first issue' to dive deeper in fabric, but it's hard to find smth..

[ghost]

Maybe we will close this issue?

+1

(alternatively, provide a link to the relevant code sections, thus a newcomer can take immediately a look at it)

[denyeart]

Since most production deployments use external builders or chaincode as a service, there isn't a need to make the default builder more complicated. The default builder is typically used in Fabric trials where the public images can be pulled. I'll go ahead and close this issue.