Dave Enyeart

Results 249 comments of Dave Enyeart

Have not heard back from PR creator. Fixed in https://github.com/hyperledger/fabric/pull/3614 instead. Closing this one.

@joshhus Feel free to fix the line wraps for the next release notes: https://github.com/hyperledger/fabric/blob/main/release_notes/v2.5.0.md

Thank you for the contribution! Please sign the commit using the instructions at https://github.com/hyperledger/fabric/pull/3191/checks?check_run_id=4941497881

@mbwhite Since we haven't received a signed commit yet, could you maybe move this one forward in a new PR? Take the inspiration from this PR and add any other...

The MSP (based on CORE_PEER_MSPCONFIGPATH) that runs the "peer channel create" command needs to be an orderer admin. This requires the certificate to be generated with an OU of "admin"...

Note that a workaround has been merged in bootstrap script to pull down amd64 when using M1 Mac (Rosetta approach that Dave K mentioned). Got confirmation that this approach works.

Closed the related fabric-gateway issue: https://github.com/hyperledger/fabric-gateway/issues/346

@bhaskarvilles Thanks for the find but it seems the fix does not work. See the error during integration test checks.

@bhaskarvilles Assuming you get the code to compile, please add an explanation in the PR and commit message of how the fix prevents the issue.

@bhaskarvilles We are asserting that there is no issue possible here. If you can describe how somebody could make such an exploit, and how you intend to resolve it, we...