Patrik Ragnarsson
Patrik Ragnarsson
You could have an app that is not an web app, but for whatever reasons, it has `rack` as a dependency. Then, the buildpack would automatically add a `web` dyno...
Inspiration: https://github.com/ffuenf/vagrant-boxes/blob/v1.0.45/.travis.yml Downloads and installs Packer, then runs `packer validate ...`.
The warning causes the tests to fail, I guess it is a good thing, so we noticed in advance. From https://github.com/sinatra/sinatra/actions/runs/9565078027/job/26367226933#step:5:25 ``` 1) Failure: IntegrationTest#test_with_puma_does_not_generate_warnings_0 [test/integration_test.rb:58]: --- expected +++ actual...
From https://github.com/sinatra/sinatra/actions/runs/9565078027/job/26367227204 ``` Failures: 1) Rack::Protection::CookieTossing with default reaction adds the correct Set-Cookie header Failure/Error: expect(last_response.headers['Set-Cookie']).to eq(expected_header) expected: ["rack.%2573ession=; domain=example.org; path=/; expires=Thu, 01 Jan [19](https://github.com/sinatra/sinatra/actions/runs/9565078027/job/26367227204#step:4:20)70 00:00:00 GMT", "rack.%2573e...0 GMT", "rack.session=;...
From https://github.com/sinatra/sinatra/actions/runs/9565078027/job/26367226933#step:5:52 ``` 4) Failure: StaticTest#test_handles_valid_byte_ranges_correctly_0 [test/static_test.rb:147]: Incorrect Content-Length for bytes=0-0. --- expected +++ actual @@ -1,3 +1 @@ -# encoding: US-ASCII -# valid: true -"1" +nil ```
From https://github.com/sinatra/sinatra/actions/runs/9313939939/job/25637216301#step:5:72 ``` 1) Error: RoutingTest#test_matches_empty_PATH_INFO_to_if_a_route_is_defined_for__0: Rack::Lint::LintError: PATH_INFO must start with a '/' and must not include a fragment part starting with '#' (origin-form) vendor/bundle/ruby/3.2.0/bundler/gems/rack-c8966d083db4/lib/rack/lint.rb:374:in `check_environment' vendor/bundle/ruby/3.2.0/bundler/gems/rack-c8966d083db4/lib/rack/lint.rb:63:in `response' vendor/bundle/ruby/3.2.0/bundler/gems/rack-c8966d083db4/lib/rack/lint.rb:41:in `call'...
Looks like Rack 3.1 brought breaking changes for us?
We had [passing tests](https://github.com/sinatra/sinatra/actions/runs/7583324414/job/20654722950#step:6:95) with `truffleruby 23.1.2, like ruby 3.2.2, Oracle GraalVM Native [x86_64-linux]` on Jan 19. We now have [failing tests](https://github.com/sinatra/sinatra/actions/runs/8432253102/job/23092338345#step:6:70) with `truffleruby 24.0.0, like ruby 3.2.2, Oracle GraalVM...
Sinatra has the some protections enabled by default https://github.com/sinatra/sinatra/blob/5640495babcb4cfd69ba650b293660b7446402da/rack-protection/lib/rack/protection.rb#L46-L53 but the reaction is set to `drop_session` https://github.com/sinatra/sinatra/blob/5640495babcb4cfd69ba650b293660b7446402da/lib/sinatra/base.rb#L1865 which renders many protections useless? If you want them to actually stop the...