sinatra
sinatra copied to clipboard
`Rack::Logger is deprecated and will be removed in Rack 3.2`
The warning causes the tests to fail, I guess it is a good thing, so we noticed in advance.
From https://github.com/sinatra/sinatra/actions/runs/9565078027/job/26367226933#step:5:25
1) Failure:
IntegrationTest#test_with_puma_does_not_generate_warnings_0 [test/integration_test.rb:58]:
--- expected
+++ actual
@@ -1 +1 @@
-[]
+["lib/sinatra/base.rb:1849: warning: Rack::Logger is deprecated and will be removed in Rack 3.2."]
2) Failure:
IntegrationTest#test_with_falcon_does_not_generate_warnings_0 [test/integration_test.rb:58]:
--- expected
+++ actual
@@ -1 +1 @@
-[]
+["lib/sinatra/base.rb:1849: warning: Rack::Logger is deprecated and will be removed in Rack 3.2."]
3) Failure:
IntegrationTest#test_with_webrick_does_not_generate_warnings_0 [test/integration_test.rb:58]:
--- expected
+++ actual
@@ -1 +1 @@
-[]
+["lib/sinatra/base.rb:1849: warning: Rack::Logger is deprecated and will be removed in Rack 3.2."]
Relevant PR: https://github.com/rack/rack/pull/2196
Also
- https://github.com/rack/rack-contrib/pull/194
- https://github.com/rack/rack/issues/2190
- https://github.com/rack/rack/pull/2197