Patrik Ragnarsson

Results 771 comments of Patrik Ragnarsson

I haven't had the time to look at this, but I just found out about this: https://github.com/github/secure_headers (...because I was [searching the rails repo](https://github.com/search?q=repo%3Arails%2Frails+Sec-Fetch-Site&type=issues) for `Sec-Fetch-Site` because I was reading...

The turbo-rails tests ([fail link](https://github.com/puma/puma/actions/runs/13226632500/job/36918427882?pr=3616#step:6:27)) are using capybara, and it seems like the changes here breaks what capybara is doing: https://github.com/teamcapybara/capybara/blob/3.40.0/lib/capybara/registrations/servers.rb#L44 Is this PR intentionally introducing breaking changes? Disclaimer: I...

> Hmm yes I just learnt about #clamp... Looks like they aren't calling #load though, which they should be doing. I think we should be validating both. Let me know...

> a `cluster/single` DSL addition What are we talking about? Maybe it should be outlined in a new issue

What's a good title for this issue? I don't think the current one correctly describes the task at hand

Did https://github.com/grpc/grpc/pull/33430 help this in any way?

Marked this as something for Puma v7 as it sounds like a change in behaviour – feel free to share any thoughts on that

Maybe @toregeschliman can review this?

Interesting discussion. > I still feel like our current behavior is a great implementation. If I may, a counterexample. I use requests to extract the `` from a requested document,...

Yes, perhaps documentation is the way forward. I can share my experience. I'm a very new user of requests, and I haven't looked at all the documentation for requests, but...