Patrik Ragnarsson

Results 771 comments of Patrik Ragnarsson

Can you find out what's causing problem here @jjb? So we know if `rake clean` should be adjusted or if there's something to document in the contributing docs.

@jjb can you try adding that to `rake clean` and see if that resolves it? Sounds like an easy solution to me, PR appreciated if so

Yeah, what if you try another web server?

Can you provide a way to reproduce the problem outside Ethon specs? Thanks

I found https://github.com/typhoeus/ethon/blob/6b0260dd6f9bf3b6491d9c2ccab104b8b71db108/spec/support/server.rb#L7 (and https://github.com/typhoeus/ethon/blob/6b0260dd6f9bf3b6491d9c2ccab104b8b71db108/spec/support/localhost_server.rb#L8) This issue is the same as https://github.com/sinatra/sinatra/issues/2000 and https://github.com/sinatra/sinatra/discussions/1999 `request.body` in Sinatra delegates to `Rack::Request`. https://github.com/rack/rack/pull/2153/files clarifies what changed in Rack. The test app in...

Doesn't sound like a problem we can address from the Sinatra side.

I saw this continuing in https://github.com/rack/rack/issues/2376 and I'll note that Sinatra is calling `Rack::Request#params` at https://github.com/sinatra/sinatra/blob/fa99a21461d4f1f5337b9b9d7a38a1b51c8f4e55/lib/sinatra/base.rb#L1181-L1189

> i propose that improvements to stat locking should go into another PR, since status quo is already inconsistent locking for stats Not sure about that, don't we want stats...

> I was not sure what made the most sense. At first, I thought to add the missing directives to the list inside the class. But then this list would...