Patrik Ragnarsson

Results 771 comments of Patrik Ragnarsson

I think it is this assumption that doesn't pan out in the above scenario: https://github.com/ruby/setup-ruby/blob/2eb6adbfb1f8850489a1f947f9421d777ea89485/bundler.js#L133-L134 https://github.com/ruby/setup-ruby/blob/2eb6adbfb1f8850489a1f947f9421d777ea89485/bundler.js#L156-L160 After `Found cache for key`, can you see `bundle clean` being run? Are you...

Maybe you can workaround this issue by not utilizing the cache for Dependabot PRs, if you can set `cache-version` dynamically when needed (otherwise set it to `0`). (Just trying to...

Here too https://github.com/sinatra/sinatra/blob/5640495babcb4cfd69ba650b293660b7446402da/rack-protection/lib/rack/protection/ip_spoofing.rb#L16-L24

Makes sense to me. Not sure I understand the "Fork Block Location" column above. (I have not looked at any code related to this)

Looks like https://github.com/puma/puma/pull/3258 aims to do this

Maybe interesting ```shell $ curl 'localhost:31337/?foo=%0' Invalid query parameters: invalid %-encoding (%0) ```

I wonder if it is the correct approach to silently remove the null byte in the `uri` method ... maybe it is good that application authors are alerted when this...

Sounds like a breaking change for Puma? Should we do this in Puma v7?

Hmm, what is the reason for not setting `rack.input` to `Puma::NullIO` when there's no body in the request? Reading https://github.com/rack/rack/pull/2115 it seem like the issue was `Puma::NullIO` not responding to...

Why was `NullIO` introduced in the first place? Anyone know the history behind it?