Patrik Ragnarsson

Results 771 comments of Patrik Ragnarsson

Yeah head works! https://github.com/sinatra/sinatra/actions/runs/9313939939/job/25637217253

It is allowed to fail. This was just me checking in and making a note after seeing the failure in the CI summary :-) Thanks for the info about 24.1.0....

There is https://github.com/oracle/truffleruby/releases/tag/graal-24.1.0 now and even https://github.com/oracle/truffleruby/releases/tag/graal-24.1.1

~~This test does not fail with rack head (3.2) https://github.com/sinatra/sinatra/actions/runs/9565078027/job/26367227454~~ Incorrect: https://github.com/rack/rack/issues/2218#issuecomment-2179237771, https://github.com/rack/rack/issues/2218#issuecomment-2179240066

Update on this from @ioquatix at https://github.com/rack/rack/pull/2219#issuecomment-2219715571 > It was being inadvertently added back in by `Response#buffered_body!` (invoked by `MockResponse#initialize`). In other words, it appears that the test is wrong,...

https://github.com/sinatra/sinatra/commit/9a01e3d4920c675219cf45d01532497c4af5dfbf added the test case that now fails (the `0..0` scenario) https://github.com/sinatra/sinatra/blob/5640495babcb4cfd69ba650b293660b7446402da/test/static_test.rb#L139-L164

`0..0` is just the first case that fails, removing it, other cases fail too

If we stop doing `headers.delete 'content-length'` ([src](https://github.com/sinatra/sinatra/blob/5640495babcb4cfd69ba650b293660b7446402da/lib/sinatra/base.rb#L298)) this test (from https://github.com/sinatra/sinatra/commit/b4126e4c972f8547d04de09c18a9543a1442ba8e) starts to fail: https://github.com/sinatra/sinatra/blob/5640495babcb4cfd69ba650b293660b7446402da/test/routing_test.rb#L164-L175

It is this change all over again: https://github.com/sinatra/sinatra/commit/1dfae3d87e236785cade93b7b2d1adbd4b450eaa If I change `value.is_a?(Rack::Files::Iterator)` to `value.is_a?(Rack::Files::BaseIterator)` the tests passes. `Rack::Files::BaseIterator` was introduced a while ago, in rack 2.2.0, in https://github.com/rack/rack/commit/3936b90697fcaf02751e596bd9dfd0e24add9b29.

https://github.com/sinatra/sinatra/commit/a1f4fa9cee4114354631cefb6316035bfbef372d aimed to fix https://github.com/sinatra/sinatra/issues/608, that issues says this commit https://github.com/sinatra/sinatra/commit/00b63ec5a5497aa2fa9777a3e899134718a13fd6 broke things; there was some discussion on that commit.