Delano comments

Results 193 comments of


                                            Delano

Gibbler and Rails

That's curious. Thanks for reporting it. I don't use rails at all so it'll be difficult for me to test and fix, but I'd happily pull in a patch.

include_class is deprecated

Thanks for the heads up. Can you submit a pull request?

Rye::Cmd.add_command breaks for programs with "-" in them (method must match program name)

Ya, I can see how that would be annoying. If you send a pull request, I'll bring it in.

Rye:Err is raised when a ssh command returns 1

I chose to return an exception for non-zero exit codes to avoid any ambiguity around successes and failures. Ideally Rye.shell would be consistent with that, but the class usage is...

Rye:Err is raised when a ssh command returns 1

@Hito01 You can pass the option `:error => false` to `Rye::Box.new` to avoid printing the `STDERR`.

Rye:Err is raised when a ssh command returns 1

You can also try adding an exception hook for the `Exception` class which does nothing but return. See: - https://github.com/delano/rye/blob/master/lib/rye/box.rb#L526 - https://github.com/delano/rye/blob/master/lib/rye/box.rb#L839

"System cannot find the path specified" error at Rye::Box.new() on Windows

Thanks for bringing this back on the radar. Can you check if the change on that PR works for you? Using`if STDIN.tty? rescue nil` instead of checking the OS.

Suggestion for some changes in box.rb

Thanks for this code review. I'll take a look soon and get back to you.

Rye::Set should not pass bad opts to Rye::Box

Ya, that seems reasonable. I'll look into it but I'm pretty swamped right now so it could take a while. If you'd like to submit a pull request with the...

add `find` command

Just an oversight, ya. Good catch.