delaaxe

Results 9 comments of delaaxe

-1 I find those constructs completely unreadable for anyone not expert in CoffeeScript (like other employees, which I'm trying to convince to use CoffeeScript). Less parens are counter productive IMO

That'll probably have to do with the fact that the "use strict"; statement has no side effect, so the optimiser cleans it out. Try compiling with the "--no-optimise" flag. This...

Anyway I think it's recommended to use strings instead of numbers for toWei()

given the sensitive nature of a wallet's code base, I'd rather not add a dependency coming from someone's personal github account

Interesting, which code analysis tool did you use to detect this?

Bundle sizes are also huge using create-react-app. Why not restructure the project on a "one file per chart type" basis in order to make tree shaking work?

@b49015 @justinhelmer When doing a production build, pdfmake.js and xlsx.js are compiled into their own bundles which never get downloaded by the browser if you don't use the PDF or...