support Ledger Nano S/SP/X devices (blind signing)

[yogh333]

support Ledger Nano S/SP/X devices (blind signing)

[janek26]

Hey, I don't think this has the chance to work this way, as you can see in the error. The background process has no access to the window object and usb methods. It would need to be it's own content script.

[yogh333]

Regarding the error it is due to the fact that the first time you add a device you have to launch the extension in a chrome tab (see Expand in settings menu). But you say that there is another solution ?

[delaaxe]

given the sensitive nature of a wallet's code base, I'd rather not add a dependency coming from someone's personal github account

[janek26]

@yogh333 maybe you can get that under the ledger org?

[yogh333]

@janek26 I am working for Ledger with my personal github account. I assume that there are several PRs coming from other github personal accounts so what is the concern here ? Code is open source, can be reviewed, commented, improved, modified etc...

[yogh333]

@janek26 Regarding this issue, did you try by first trying to open the extension in a tab before trying to connect to a Ledger device ?

[yogh333]

Hello, What is the status for the merge ? If there is anything blocking, please tell me so I can help...

[janek26]

most likely this won't get merged until we support multiple account types

Hey, we're still considering how to integrate multiple account types the best. We need to offer an end user ready experience, and just adding one button per signer type is not scaleable.

Also it should be a smooth experience for users to use ledger, even if they don't know that they need to open the extension in fullscreen mode.

We'll keep you up to date as our plans evolve, but I don't think this will be merged in the short term.

[janek26]

close in favor of #1218