Taylor Hornby
Taylor Hornby
(Copying this comment from the other ticket where I was doing my audit). Checking the "TODO: check whether this is justified" in the unlinkability proof for DiversifyHash: Let (P, pk)...
The "Value pool" sentence is kind of vague, maybe we should specify the algorithm for it. It's important because it's how a pour's validity is bound to a transaction's validity.
I noticed in lightwalletd's logs that it was excluding the price from binance because it was 55.8 whereas the actual price of ZEC was around 42.7. Their APIs for USDC...
In passing, I noticed that this fork of lightwalletd is missing this bug fix, without which the server can crash when a reorg occurs at just the right time: https://github.com/zcash/lightwalletd/pull/409....
This is a really bad idea: ``` $cipherText->key; ``` The interface should be changed so that the key is never stored in the ciphertext... because it will lead naive users...
This is wrong. In the fallback random thing. ``` // Let's make it a byte. $random .= chr($source % 255); ``` It should be 256, otherwise the value 255 is...
I'm not totally sure if this is a problem in gpg-mailgate or in Thunderbird. When an HTML-only mail is recieved, it gets encrypted, and Thunderbird no longer displays it correctly....
There is an issue with long filenames: ``` --------------020908070905010506000203 Content-Type: application/octet-stream; name="(24) [J Majik & Wickaman Feat. Dee Freer] In Pieces.mp3.pgp" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="(24) [J Majik & Wickaman...
See this comment: https://github.com/defuse/passgen/commit/123e2e6646cfa390f008d0d41115a001d78cfee8#commitcomment-18471707
Passgen should build and be usable on Windows systems.