Taylor Hornby

Run Siderophile on Travis-CI

2

This adds a script to run [siderophile](https://blog.trailofbits.com/2019/07/01/siderophile-expose-your-crates-unsafety/) against all of the crates in librustzcash, and makes it run on Travis-CI. You may want to hold off on merging this because...

Document potential memory use of functions that deserialize CompactSize-containing data structures

1

(Originally reported by @teor2345 through security channels.) The maximum value of a CompactSize field is [32MiB](https://github.com/zcash/librustzcash/blob/05bd98b79691b1d89b5cba304b6228ac192c5d17/zcash_primitives/src/serialize.rs#L4). Parsers that make use of the CompactSize value to pre-allocate memory for parsing the...

Internal Security Review Results (of note-spending-v5 branch)

3

I looked at all of `zcash_client_backend`, `zcash_client_sqlite`, and some of `zcash_primitives` in revision ae63116f639847e54716fbf47f19589d12038a16. I was only focused on stuff related to the mobile wallet. I'm posting here instead of...

Assertion `uResultHeight == rewindHeight` failed

8

I was trying to run the smoke tests and I somehow managed to get its wallet into a bad state that triggers the following assertion failure. I have a copy...

Use the Ubuntu 20.04 clang package which works on Arch Linux

2

This fixes #5488 but it might break the build on Ubuntu 16.04. Let's see what CI says...

This is pretty hacky code so obviously it shouldn't be accepted as-is, but it worked for my needs.

Possible assembler bugs

3

Quote from email: ``` Disassembling of 0F 84 2C 01 00 00 gives back je 0x132. On the other hand, assembling of je 0x132 gives back OF 84 2E 01...

Add disclaimer to big number calculator that it doesn't do arbitrary-precision decimal arithmetic

2

Some users have been confused by this.