Roman Shtylman

changes LGTM - @dogoepp can you look into the failing melodic and noetic CI and see if thats related to this change?

CI is failing because the tests are failing.

ping?

I was just playing around with some various modules. I will move the function and see what effect that has. As for the requires, you could ignore ones you don't...

Right now I am just porting existing behavior in preparation for a "remove connect" PR for express. Once that lands we can start evaluating which pieces need to be updated...

I don't use this session stuff so someone who does should weigh in.

@jonathanong please add people. I don't really care about this middleware in its current state :)

I could agree with that. PR would be appreciated.

Any action on my part or is this just a tracking issue?

I was caught by this issue. the _csrf field is actually the _csrf secret and not the csrf token which the user must set into a cookie on their own.