session icon indicating copy to clipboard operation
session copied to clipboard

cookies and keygrip

Open jonathanong opened this issue 11 years ago • 8 comments

the plan was to use https://github.com/jed/cookies for cookie parsing and getting. express could include it as well via proto or something.

https://github.com/senchalabs/connect/issues/382 https://github.com/visionmedia/express/issues/1139

not exactly sure what to do though because the old cookieParser is incompatible with the new cookies since they both use req.cookies.

we could just move that into a pending v2 or something. don't know. i feel like this whole lib is jank and should be rewritten anyways.

@visionmedia

jonathanong avatar Feb 16 '14 01:02 jonathanong

Right now I am just porting existing behavior in preparation for a "remove connect" PR for express. Once that lands we can start evaluating which pieces need to be updated etc.

Express is highly coupled to connect historically making it pretty annoying to use and update particular pieces. This separation aims to change that.

defunctzombie avatar Feb 16 '14 01:02 defunctzombie

yup. makes sense just for extraction. i'm just wondering about its future by itself as well as its future with express.

jonathanong avatar Feb 16 '14 01:02 jonathanong

going to move the connect session issues here. are you going to be active maintaining this? otherwise i'm going to add people who want to help to a "session" dev team

jonathanong avatar Feb 16 '14 01:02 jonathanong

I don't use this session stuff so someone who does should weigh in.

defunctzombie avatar Feb 16 '14 01:02 defunctzombie

@jonathanong please add people. I don't really care about this middleware in its current state :)

defunctzombie avatar Feb 16 '14 01:02 defunctzombie

haha okay we can figure out sessions for express 4 later then. it would probably be better just to create session middleware per store anyways. and it'll take people time to migrate to v4 so there will be time.

i'm going to add people, then remove the issues and code from connect

jonathanong avatar Feb 16 '14 01:02 jonathanong

yeah per-store like koa is the easiest, maintaining one interface is definitely preferable for interopt but not a huge deal

tj avatar Feb 18 '14 03:02 tj