deepin-ci-robot
deepin-ci-robot
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *zccrs*, *zzz6519003* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Funilang). Needs approval from...
Hi @kuchune. Thanks for your PR. :smiley:
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *kuchune* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-kwin). Needs approval from an...
Hi @kuchune. Thanks for your PR. I'm waiting for a [linuxdeepin](https://github.com/orgs/linuxdeepin/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on...
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *wineee* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-kwin). Needs approval from an...
### deepin pr auto review 关键摘要: - 在CMakeLists.txt中,`if (KF_MAJOR_VERSION EQUAL "6")`条件判断应该使用`==`而不是`=`,因为`=`是赋值操作符,而不是比较操作符。 - 在deepin-kglobalacceld.desktop.in文件中,`Exec=@KDE_INSTALL_FULL_LIBEXECDIR@/kglobalacceld`应该检查`kglobalacceld`是否存在,以避免运行不存在的可执行文件。 - 在debian/deepin-kwin-common.install文件中,新增的安装路径`etc/xdg/autostart/deepin-kglobalacceld.desktop`应该确保该路径是正确的,并且有相应的权限设置。 是否建议立即修改: 是
Hi @kuchune. Thanks for your PR. :smiley:
Hi @kuchune. Thanks for your PR. I'm waiting for a [linuxdeepin](https://github.com/orgs/linuxdeepin/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on...
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *kuchune*, *rb-union* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-deb-installer). Needs approval from...
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *Lighto-Ku*, *liyigang1*, *max-lvs* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdde-file-manager). Needs approval...