deepin-ci-robot
deepin-ci-robot
Hi @packit-public-repos-bot. Thanks for your PR. I'm waiting for a [linuxdeepin](https://github.com/orgs/linuxdeepin/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on...
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *kuchune* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-icon-theme). Needs approval from an...
Hi @kuchune. Thanks for your PR. :smiley:
Hi @kuchune. Thanks for your PR. I'm waiting for a [linuxdeepin](https://github.com/orgs/linuxdeepin/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on...
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *re2zero* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-image-viewer). Needs approval from an...
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *tsic404* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-kwin). Needs approval from an...
### deepin pr auto review 代码审查意见： 1. 代码修改中，`X11Window::NETMoveResize` 函数中新增了对 `isDock()` 的检查，这是一个好的实践，因为它增加了代码的灵活性和可配置性。但是，需要确保 `isDock()` 函数的实现是正确的，并且与窗口的预期行为一致。 2. 在 `X11Window::NETMoveResize` 函数中，`setUnrestrictedInteractiveMoveResize` 的调用被修改为 `setUnrestrictedInteractiveMoveResize(isDock());`。这个修改可能会影响窗口的交互行为，需要确认这个改动是否符合预期的功能需求。 3. 在 `Window::handleInteractiveMoveResize` 函数中，对 `isResizable()` 的检查被修改为 `(!isDock() && !isResizable())`，这可能会改变窗口的交互行为。需要确保这个改动是经过充分测试的，并且不会引入新的问题。 4. 在...
@tsic404: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests: Test name | Commit | Details | Required | Rerun...
Hi @kuchune. Thanks for your PR. :smiley:
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *kuchune* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdde-launcher). Needs approval from an...