deepin-ci-robot
deepin-ci-robot
Hi @kuchune. Thanks for your PR. I'm waiting for a [linuxdeepin](https://github.com/orgs/linuxdeepin/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on...
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *18202781743*, *kegechen* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fqt5platform-plugins). Needs approval from...
### deepin pr auto review 关键摘要: - 在`DNoTitlebarWindowHelper::DNoTitlebarWindowHelper`构造函数中,`g_pressPoint.remove(this);`可能会导致未处理的初始化问题,如果`this`已经在`g_pressPoint`中存在,则调用`remove`会失败。 - 在`DNoTitlebarWindowHelper::windowEvent`函数中,`g_pressPoint[this]`的赋值操作应该在`if`语句块之外,以避免潜在的未初始化问题。 - `QPointF delta = me->globalPos() - g_pressPoint[this];`计算了鼠标移动距离,但没有考虑到鼠标移动的累积效应,可能会导致在较短距离下误判移动事件。 - `if (delta.manhattanLength() < QGuiApplication::styleHints()->startDragDistance())`中的`QGuiApplication::styleHints()->startDragDistance()`应该使用`QApplication::startDragDistance()`,因为`QGuiApplication`在Qt 6中已被移除。 - `self->isEnableSystemMove(winId)`调用了一个未在更改前的代码中定义的函数`isEnableSystemMove`,需要确认该函数的存在性和作用。 是否建议立即修改: 是
Hi @kuchune. Thanks for your PR. :smiley:
Hi @kuchune. Thanks for your PR. I'm waiting for a [linuxdeepin](https://github.com/orgs/linuxdeepin/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on...
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *18202781743*, *kuchune* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fqt5platform-plugins). Needs approval from...
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *kuchune* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-picker). Needs approval from an...
Hi @kuchune. Thanks for your PR. :smiley:
Hi @kuchune. Thanks for your PR. I'm waiting for a [linuxdeepin](https://github.com/orgs/linuxdeepin/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on...
[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *deepin-ci-robot* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-picker). Needs approval from an...