qt5platform-plugins icon indicating copy to clipboard operation
qt5platform-plugins copied to clipboard

fix

Open 18202781743 opened this issue 1 year ago • 2 comments

  • fix: 向日葵中点击文管窗口标题时直接进入移动窗口状态
  • fix: 共享库二进制兼容

18202781743 avatar Aug 12 '24 08:08 18202781743

TAG Bot

New tag: 5.6.34 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #253

deepin-bot[bot] avatar Aug 21 '24 09:08 deepin-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Aug 27 '24 06:08 deepin-ci-robot

deepin pr auto review

关键摘要:

  • DNoTitlebarWindowHelper::DNoTitlebarWindowHelper构造函数中,g_pressPoint.remove(this);可能会导致未处理的初始化问题,如果this已经在g_pressPoint中存在,则调用remove会失败。
  • DNoTitlebarWindowHelper::windowEvent函数中,g_pressPoint[this]的赋值操作应该在if语句块之外,以避免潜在的未初始化问题。
  • QPointF delta = me->globalPos() - g_pressPoint[this];计算了鼠标移动距离,但没有考虑到鼠标移动的累积效应,可能会导致在较短距离下误判移动事件。
  • if (delta.manhattanLength() < QGuiApplication::styleHints()->startDragDistance())中的QGuiApplication::styleHints()->startDragDistance()应该使用QApplication::startDragDistance(),因为QGuiApplication在Qt 6中已被移除。
  • self->isEnableSystemMove(winId)调用了一个未在更改前的代码中定义的函数isEnableSystemMove,需要确认该函数的存在性和作用。

是否建议立即修改: 是

deepin-ci-robot avatar Aug 27 '24 06:08 deepin-ci-robot