deepin-ci-robot

Results 363 comments of deepin-ci-robot

Hi @kuchune. Thanks for your PR. :smiley:

Hi @kuchune. Thanks for your PR. I'm waiting for a [linuxdeepin](https://github.com/orgs/linuxdeepin/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on...

[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *kuchune*, *rb-union* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-draw). Needs approval from...

Hi @transifex-integration[bot]. Thanks for your PR. I'm waiting for a [linuxdeepin](https://github.com/orgs/linuxdeepin/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on...

[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *BLumia*, *transifex-integration[bot]* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-manual). Needs approval from...

[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *myk1343* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-editor). Needs approval from an...

### deepin pr auto review 代码审查意见: 1. 在`StartManager::autoBackupFile`函数中,新增了一个条件判断`if (m_windows.isEmpty()) { return; }`。这个改动是合理的,可以避免在`m_windows`为空时执行不必要的操作。 2. 在`Window::saveAllFiles`函数中,使用了`QMap wrappers = m_wrappers;`来复制`m_wrappers`。这个做法虽然可以避免直接修改原始数据,但每次调用`saveAllFiles`时都会创建一个新的`QMap`对象,这可能会影响性能。建议在函数内部直接使用`m_wrappers`,或者将`m_wrappers`的引用作为参数传递给函数。 3. 在`Window::saveAllFiles`函数中,对于每个文件保存操作,都使用了`m_tabbar->setCurrentIndex(i);`来切换到当前文件所在的标签页。这个操作可能会影响性能,因为每次切换标签页都需要重新布局和渲染界面。建议在保存文件之前保存当前活动的标签页索引,保存完成后恢复该索引。 4. 在`Window::saveAllFiles`函数中,对于每个文件保存操作,都使用了`QFileInfo fileInfo(filePath);`来获取文件信息。这个操作可能会影响性能,因为每次获取文件信息都需要访问文件系统。建议将文件信息存储在`EditWrapper`对象中,避免重复访问文件系统。 5. 在`Window::saveAllFiles`函数中,对于每个文件保存操作,都使用了`if (res == 0 || res ==...

[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *re2zero* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-editor). Needs approval from an...

[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *transifex-integration[bot]* The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=linuxdeepin%2Fdeepin-editor). Needs approval from an...

Hi @transifex-integration[bot]. Thanks for your PR. I'm waiting for a [linuxdeepin](https://github.com/orgs/linuxdeepin/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on...