Robo

Results 334 comments of Robo

Can you also check if the crash is present with our insiders https://code.visualstudio.com/insiders/ which comes with a newer version of the runtime.

Yeah its from a fork which has the find API based on https://github.com/electron/electron/pull/28274

Same here, please update the tests with changes from https://github.com/electron/electron/pull/41705. Thanks!

> draw by GTK (my implementation)? I think this what we want for WCO so that controls can adjust properly to the system theme. I guess the question now is...

Sorry for the delay here, need some time to verify the changes. I will have an update later this week.

There is also the issue with theme adjustment with the current implementation, **native titlebar:** ![Screenshot 2024-04-24 at 17 21 22](https://github.com/electron/electron/assets/964386/fdeecf4f-baaa-4266-a717-aa41492c8c59) **custom titlebar:** ![Screenshot 2024-04-24 at 17 21 35](https://github.com/electron/electron/assets/964386/15f69d3c-e864-4b1c-b1ca-c3b05bd5559f) I believe...

Missed that, thanks for clarifying! If that works well for both x11 and wayland then seems like a better route. @codebytere thoughts ?

Can you update the PR with changes from https://github.com/electron/electron/pull/41705, thanks!

Is the network service fine to be created before IO threads are setup ? We don't allow net module in the main process before app ready for related reasons. I...

> It is common to want to have an application/executable that can run both in a GUI mode and in a non-GUI, batch command line mode. @tewk what scenarios require...