Robo

Looks like the PR supersedes https://github.com/electron/electron/pull/35760, should we close that in favor of this PR ? Additionally, can we address https://github.com/electron/electron/pull/35760#pullrequestreview-1116889885 as part of this PR ?

The failing WoA test is from newly added one ``` not ok 156 default behavior app.setNodePreload throws when path outside of resources path is passed expected [Function] to throw error...

Yes both the mentioned features are not protection against untrusted code executed in the process but rather against external actors, both the described features in VS Code are specific to...

Looks like a follow-up to https://github.com/nodejs/node-v8/issues/227, possibly newer code paths need to be guarded in Node.js

I have been looking into this issue recently and was able to repro one of the crash scenarios with pointer focus into the application, debugging showed that an invalid layer...

Thanks for testing @tengyifei , that is a good catch I haven't tested multiple window launches in my setup. Just to confirm the steps to repro, 1) Launch VS Code...

Sorry for the delayed response and thanks for testing the builds, it is good to know that startup crash is avoided. Based on the traces from https://github.com/electron/electron/issues/39449#issuecomment-1793113439 there is one...

@miniak addressed in https://github.com/electron/electron/pull/38891/commits/f395765d90237d0f8f54073fc1f0e975c3a2e305

yeah the version check is not needed, removed it in https://github.com/electron/electron/pull/38891/commits/b9de43a94195801b1beaf54d7f1c2596f1efca3b

Failing x64-testing test is flaky, failed on main as well https://ci.appveyor.com/project/electron-bot/electron-x64-testing/builds/47407765/job/vuwa47496ajr1vfu/tests