Robo
Robo
@aeschli @bpasero I had to remove the build configuration https://github.com/parcel-bundler/watcher/blob/478a1ad66d44663cb24f3f73428ff2b52a244098/binding.gyp#L5 to bubble up the exception so that it ended up creating a coredump. I had to make this change only...
Yup that change would address the crash since it replaces the problematic pointer with a copy, also verified the change locally with the above test case. But we need to...
@bpasero yup that sounds good.
Sorry I was planning to update before requesting review, ~~will address it today.~~ @nornagon updated the explainer section, PTAL. Thanks!
Thank you for taking the time to do a thorough review of this change! > I don't want to miss @erickzhao's comment that we should add more documentation for this...
Have created https://github.com/electron/electron/pull/36074 as follow-up for the docs change. Allows for easier reivew, I will merge this PR today once build is green.
Failing test is unrelated and is also flaky on main branch, merging.
Failing tests are unrelated, merging.
FYI, vscode loads node-pty in a process that has only single v8 context for the lifetime of the application, hence this is not an issue when moving forward with newer...
Reopening because we reverted Electron 22 for March milestone.