Declan Kelly
Declan Kelly
So would you suggest showing multiple examples that all use different data? Or using the data structure in a generic setting, for example in some algorithm like shortest path?
Also, I had some thoughts about making the container not hold any data (thus removing the generic parameter), but actually returning symbolic keys that would represent the nodes in the...
@probonopd Is it possible to test a PR to see if the `.desktop` file generation will work? I've changed the configuration in PR #164, hopefully that will fix this issue
I'll reopen this until we verify that the `.desktop` file passes validation
[bindgen-0.69.4/time.rs:38:24](https://github.com/rust-lang/rust-bindgen/blob/main/bindgen/time.rs#L38-L39): ```rust let time = (elapsed.as_secs() as f64) * 1e3 + (elapsed.subsec_nanos() as f64) / 1e6; ``` [`indicatif-0.17.8/src/state.rs:655`](https://github.com/console-rs/indicatif/blob/main/src/state.rs#L655): ```rust d.as_secs() as f64 + f64::from(d.subsec_nanos()) / 1_000_000_000f64 ``` [`serde_with-3.7.0/src/utils.rs:117:5`](https://github.com/jonasbb/serde_with/blob/master/serde_with/src/utils.rs#L117) ```rust (dur.as_secs()...
Thank you @blyxyas for reviewing! I'll address your comments in my next attempt. I wanted to get your opinion on the lint category versus the number of false positives. I...
I pushed a new revision addressing 3/4 comments, let me know your thoughts on the last comment I left unresolved. Thanks again!
Oh sorry! I added the commit just because it was the easiest way to apply your suggestions, I'm still planning to work on the other comments/open that issue possibly
> the topological ranking is different for nodes that should have the same ranking I think you're referring to the `usize` rankings returned by the [`DescendantsUnsorted` iterator](https://docs.rs/incremental-topo/latest/incremental_topo/struct.DescendantsUnsorted.html), unfortunately those values...
> Regarding EXPONENTIAL_FORMAT_THRESHOLD, I think I'll make that a compile-time configurable; like [RUST_BIGDECIMAL_DEFAULT_PRECISION](https://github.com/akubera/bigdecimal-rs/blob/trunk/build.rs#L24C33-L24C33). Sounds good to me! That is a cool technique you're using in the `build.rs` > Is that...