Declan Kelly
Declan Kelly
Nice work on adjusting the rule! I like the latest iteration, focusing in on the placement of the digits really brings it into focus > the last one there is...
I left some nonblocking comments (on my own PR hahaha), let me know what you think! I can go ahead and implement anything, I feel bad making you do all...
> I didn't mean to force push onto your branch, but if you like the changes I'm glad I did. I'm glad you did! The changes you made look good
Thanks for all your work on this @akubera !
I added the rest of the requested changes to the commit, and I'm planning to cut that issue about recognizing `(duration.as_secs() * 1000) as f64` as a separate issue once...
Thanks for all your work in this code review! And sorry about the mini-hiatus I took in the middle 😁 . I'm looking forward to merging this in! I'm still...
Also, should I respond to questions/comments on the Zulip thread? Or is that mostly for core contributors?
Hey @xFrednet, I am planning to continue, but it might take me a second to get back to this. Thanks for checking in!
@ian-r-rose Thank you for the review!
Hey @ian-r-rose thanks again for another review. We've addressed your points with some PRs and some explanations: - With the respect to the `Signal` combining stuff I have jupyterlab/jupyterlab-statusbar#60 which...