Daniel Dudt

Results 34 comments of Daniel Dudt

Similar to #1016, I already have plans to use this in coil optimization tests for #977. In an effort to not add redundant unit tests, I vote to skip testing...

> I think there still should be tests here as it is not clear to me if this can be used to fix only the currents in a subset of...

Let's get rid of support for the Poincare BC from a text input file in this PR

FYI Thomas is already working on this. Maybe we can combine his work with this.

This PR is ready except it is waiting on #1016 to finish adding/editing tests.

We should clean up the code organization here. If this PR is meant to convert an EFIT input file into a DESC input file, then it should be a method...

I had tried simply changing the definition of $\psi(\rho)$ in the [compute funtion](https://github.com/PlasmaControl/DESC/blob/master/desc/compute/_profiles.py#L34), but that didn't seem to work well for basic tokamak equilibrium solves. It's difficult to compare because...

> I think the final ripple that people care about is epsilon_eff not epsilon_eff^(3/2). The rule of thumb is to have a ripple(epsilon_eff) < 1-2%. So, I would suggest doing...

This issue might be related to a recent commit [9a78600](https://github.com/PlasmaControl/DESC/pull/956/commits/9a78600edba03e6f9c184a2b289f5af2b7518a54) where I found I had to use `np` instead of `jnp` when working with class attributes that should be constant...

> Feels really weird that going from m=8 to m=9 makes such a big difference? @dpanici are you sure this PR is necessary? The notebooks on master look like they...