Dan Streetman

Results 26 comments of Dan Streetman

technically looks ok, but these kind of user-facing parameters are dangerous to add into stable releases *before* upstreaming; we do not want to add and release a config param that...

Note that the current PR does *not* backlevel the grub sbat level, so this requires our grub to get updated to sbat grub,4 (it's currently at grub,2). Depending on if...

> Note that the current PR does _not_ backlevel the grub sbat level, so this requires our grub to get updated to sbat grub,4 (it's currently at grub,2). > >...

> > Note that the current PR does _not_ backlevel the grub sbat level, so this requires our grub to get updated to sbat grub,4 (it's currently at grub,2). >...

being reviewed upstream here https://github.com/rhboot/shim-review/issues/387

> Just marking this change as "Request Changes" to hold it until we get a stable build for preview. I'm not sure how necessary it is for that. Happy to...

And here is the diff between our current filesystem scripts and the updated filesystem scripts: ``` --- /tmp/filesystem-scripts-a 2024-03-13 11:25:20.133313074 +0000 +++ /tmp/filesystem-scripts-b 2024-03-13 11:25:25.657308939 +0000 @@ -1,14 +1,46 @@...

> +posix.symlink("usr/lib", "/usr/lib/debug/lib") > +posix.symlink("usr/lib", "/usr/lib/debug/lib") Note that our mis-assignment of `%_lib` as `lib` instead of `lib64` causes duplicate entries for `lib` (and leaves out entries for `lib64`). I was...

> I was going to fix this in #8152 but left it in with just a comment added specifically, https://github.com/microsoft/azurelinux/pull/8152/commits/45333481f6cbb4295bf57648277efe3036e70a92

and files diff (with each listing edited to remove differing sizes and timestamps): ``` --- /tmp/filesystem-a 2024-03-13 11:37:13.616858549 +0000 +++ /tmp/filesystem-b 2024-03-13 11:37:24.168851966 +0000 @@ -1,121 +1,193 @@ +dr-xr-xr-x 2...