Dmitriy Dolovov
Dmitriy Dolovov
I would recommend to use `v2` of binary signatures (with mangled names included into the rendered signature text) vs `v1` (with only hashes).
In the future we might implement v3 of signatures. Do I get it right that no changes will be required in the compatibility validator, it will support new version of...
There are two "merge" commits which are undesirable. The single meaningful commit should be added as a result of rebasing on top of fresh `master` branch.
I would highly recommend to split the commit into two separate commits: 1. The one that makes ZIP FS accessor available not only for JS but also for all KLIB-based...
The commit message should contain a YT ticket number. It's better to put it onto a separate line. Example: ``` Some explanation. ^KT-00000 ```
I think, it worth adding `KlibLoaderSpec.zipFileSystemAccessor()` calls to: - `loadMetadataKlibs()` - https://github.com/JetBrains/kotlin/blob/6d55c67eef914cb1ee8b9fa5cd4369446723f962/compiler/ir/serialization.common/src/org/jetbrains/kotlin/backend/common/loadMetadataKlibs.kt#L17 - `loadNativeKlibsInTestPipeline()` - https://github.com/JetBrains/kotlin/blob/6d55c67eef914cb1ee8b9fa5cd4369446723f962/compiler/ir/serialization.native/src/org/jetbrains/kotlin/backend/konan/serialization/loadNativeKlibs.kt#L30
GH shows that there is a source conflict. Please rebase on fresh `master`, then I will run IC internally.
Please write a good commit message according to our rules: https://github.com/JetBrains/kotlin/blob/master/docs/code_authoring_and_core_review.md#commit-messages-and-yt-tickets The YouTrack ticket number should be specified in the commit message.
> Thanks for the documentation, just updated the commit, what do you think now? Looks good. Thanks. Let me run a few tests on our internal CI before merging it,...
> > Thanks for the documentation, just updated the commit, what do you think now? > > Looks good. Thanks. Let me run a few tests on our internal CI...