kotlin icon indicating copy to clipboard operation
kotlin copied to clipboard

Move the ZipFIleSystemAccessor configuration from JSConfiguration to common klib configurations and add compiler arguments.

Open aviroop-123 opened this issue 7 months ago • 5 comments

Enabling cached ZipFileSystemAccessor for Kotlin Native.

Closes: https://youtrack.jetbrains.com/issue/KT-79675/

aviroop-123 avatar Jul 29 '25 19:07 aviroop-123

There are two "merge" commits which are undesirable. The single meaningful commit should be added as a result of rebasing on top of fresh master branch.

ddolovov avatar Aug 07 '25 17:08 ddolovov

I would highly recommend to split the commit into two separate commits:

  1. The one that makes ZIP FS accessor available not only for JS but also for all KLIB-based compilers.
  2. The one that adds fine-tuning.

ddolovov avatar Aug 07 '25 17:08 ddolovov

The commit message should contain a YT ticket number. It's better to put it onto a separate line. Example:

Some explanation.

^KT-00000

ddolovov avatar Aug 07 '25 17:08 ddolovov

I think, it worth adding KlibLoaderSpec.zipFileSystemAccessor() calls to:

  • loadMetadataKlibs() - https://github.com/JetBrains/kotlin/blob/6d55c67eef914cb1ee8b9fa5cd4369446723f962/compiler/ir/serialization.common/src/org/jetbrains/kotlin/backend/common/loadMetadataKlibs.kt#L17
  • loadNativeKlibsInTestPipeline() - https://github.com/JetBrains/kotlin/blob/6d55c67eef914cb1ee8b9fa5cd4369446723f962/compiler/ir/serialization.native/src/org/jetbrains/kotlin/backend/konan/serialization/loadNativeKlibs.kt#L30

ddolovov avatar Aug 07 '25 17:08 ddolovov

GH shows that there is a source conflict. Please rebase on fresh master, then I will run IC internally.

ddolovov avatar Aug 21 '25 17:08 ddolovov