Dom Delnano

Results 266 comments of Dom Delnano

@hcliff I found the issue with the tests. I pushed a fix here #25. It was related to the fact that you moved the `Accept` call into `NewServer` which blocks...

@hcliff I added that because I had issues with the signal handling code cleaning up after itself. Unfortunately when I wrote that existing code it was very had to get...

@hcliff yea I know 🙈 . Cool thanks for the tip.

Thank you for the error report, can you please post your hookfiles and I should have some time to dig into this tonight.

@grounded042 so I am able to reproduce the issue and also am pretty confident I know why it is occurring. [This](https://github.com/grounded042/goodman-set-cookie/blob/master/main.go#L10) line here will create a header like so ```...

@grounded042 a little update, I am struggling to reproduce this in a testing environment because I am trying to add a new cucumber / aruba test and since I am...

@ChinmayaSharma-hue the Pixie team always welcomes support for new protocols and we would be happy to work with you through this. If you want to talk more details, it would...

Sounds good and I forgot to mention that we have [two](https://github.com/pixie-io/pixie/blob/d81a9fe3c3f1ab4163cfb1286accdf0d840573df/src/stirling/protocol_contribution_guide.md) protocol [contribution](https://github.com/pixie-io/pixie/blob/d81a9fe3c3f1ab4163cfb1286accdf0d840573df/src/stirling/protocol_contribution_guide_part2.md) guide docs that are helpful to check out.

@wnz27 can you provide the `kubectl describe` output of those pods? That should help explain why the image pull is failing.

@foolishhumans @yantingqiu could you please provide a pixie-diag (https://github.com/wreckedred/pixie-diag) of your cluster? It would be helpful to confirm if your deployment matches against some of the previous bug reports.