Dom Delnano
Dom Delnano
@kirannhegde did you get a chance to review the list?
@oazizi000 @yzhao1012 this is ready for some early feedback. The part I'm specifically seeking feedback on is the approach for detecting when to use the boringssl data structure offsets and...
@yzhao1012 @oazizi000 this is ready for a more thorough review now.
@yzhao1012 your comments should be addressed, so this is ready for another look when you have the chance.
Can you post some code examples. It’s very difficult for me to help without that.
@noisyscanner I actually don't remember what state I left this in other than that this PR didn't do what I was hoping. I'll try to revisit this issue this week.
Yea using the gob encoding makes this much more complicated :). I think I wanted to see if I could switch it to use json encoding so that this issue...
@m50 sorry for getting back to you late on this and I really appreciate your contribution! I haven't had a chance to look into why the build is failing. I...
@m50 please rebase on master now that I've fixed the majority of the issues with the test suite. The build still won't pass but I'll be able to do any...
sorry guys was out of town but I will look at #23 and this hopefully this week.