Dom Delnano

Results 266 comments of Dom Delnano

@aslak11 thanks for giving this another pass. I hope to be able to review this over the next week. Unfortunately the Jenkins job is broken due to #313. As part...

@aslak11 I still haven't had a chance to review this, but we need to track down the following test failures. This output was collected from the Jenkins job that ran...

Since there hasn't been activity here I'm going to close this pull request. I'm happy to assist if/when you are able to consider the details and test failures mentioned above.

The pixie repo seems to use this "multiarch" tagged image. ``` $ git grep 'pixie-dev-public\/curl' | grep '^k8s' k8s/cloud/base/ory_auth/kratos/kratos_deployment.yaml: image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd k8s/devinfra/buildbuddy-executor/values.yaml: image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd k8s/vizier/base/kelvin_deployment.yaml: image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd k8s/vizier/base/patch_sentry.yaml: image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd...

I missed that this wasn't the pixie-operator helm chart, but the newrelic-pixie chart. I believe we need to replace [this image](https://github.com/newrelic/helm-charts/blob/647f0f4fb7a19c4d7805ffec3a56e95ad56b4947/charts/newrelic-pixie/templates/job.yaml#L24) with the one I mentioned above.

After investigating this more, the `curl` image isn't the only one to address. The [newrelic/newrelic-pixie-integration](https://github.com/newrelic/newrelic-pixie-integration/) repo isn't publishing container images for ARM. I've validated with @maxlemieux's help that if those...

The` newrelic/newrelic-pixie-integration` repo's v2.2.0 release supports ARM builds now. We can now update the helm-chart to use this version and fix the curl issue mentioned above.

This will be addressed once #1198 is merged and a new nri-bundle release is made. Thanks for all your help through this @maxlemieux!

> What do you think of allowing users to add constraints and target_settings to the SDKs' toolchain definitions? This would allow for great flexibility and keep the complexity out of...

@fmeum [here](https://github.com/bazelbuild/rules_go/commit/2edc6ae7d25cc573ebacf0268e8b57f86e4ac76d) is where I've gotten so far. Apologies for the rough shape it's in. I primarily `print`'ed my way to its current form while running the `//tests/core/boringcrypto:boringcrypto_test` with toolchain...