Dom Delnano

Results 266 comments of Dom Delnano

There isn't a `memory_min` parameter for the VM resource at the moment and as you both have seen there isn't control over the dynamic values. I definitely agree that the...

I was expecting the diff 'as is' to be pretty nasty, which is why I tried to keep the code formatting intact initially. I'll see how difficult it is to...

@vihangm my latest approach gets the files formatted with minor whitespace differences. It required quite a few changes to the amqp code generation file. The changes to `amqp_code_gen.py` could be...

Sounds good :+1:. I've updated the branch based on the initial approach and it's ready for review now.

One minor comment otherwise this lgtm!

I was able to deploy the `px-mongo` demo by following the demo README instructions and verified that the `http_data` and hand written `mongodb_data` script show the expected data. The only...

@aimichelle are we able to close this? If I recall correctly, you fixed this shortly after this was reported.

@truegilb thanks for contributing to pixie and sorry this wasn't merged in a timely manner! We need to switch the images to ghcr.io in addition to your fix, so I've...

@AdityaAtulTewari sorry for the late reply here. The solution I envisioned was what I've implemented in https://github.com/pixie-io/pixie/commit/3bab3f0bdf03b8ffddb7a58138c2f4d3a64b3ec4. That change isn't production ready, but shows how the `pl_bpf_cc_resource` bazel rule can...

@shamoi-te the jwt signing key is created as part of step 6 ([source](https://github.com/pixie-io/pixie/blob/dffdb3b681f35583cc3749ca2ecb56593c29f752/scripts/create_cloud_secrets.sh#L27-L28)). The rest of the deploy process should template the yamls with the jwt key created from that...