David Cuadrado comments

Results 60 comments of


                                            David Cuadrado

Add validator for E164 format

the link is missing

Icon and create an organization account

yes, MIT

Panics/errors on previous benchmarks should be ignored

this can be produced if the benchmark has a fixed dependency that changed or was broken with the time

shouldn't the XML be canonicalized before calculating the digest/hash value?

I've been looking at this but I still don't have a solution, the transform block is supposed not canonicalize the block but apparently it isn't doing it. I'll try to...

shouldn't the XML be canonicalized before calculating the digest/hash value?

so after commenting out this `if` https://github.com/ma314smith/signedxml/blob/master/exclusivecanonicalization.go#L199 requests to SOAP servers work, at least in my case. but that condition should be there for a reason so I'm not sure...

shouldn't the XML be canonicalized before calculating the digest/hash value?

I tried adding inclusive namespaces but it didn't work and xmlsec which is what everybody uses doesn't need it, it automatically adds the missing namespace

Fix race in Diff printer

this one doesn't completely fix the issue but it helps, I think it should be merged for now. this issue is very frustrating

Fix race in Diff printer

@georgelesica-wf can you take a look at this one?

Fix race in Diff printer

@georgelesica-wf are you running the tests with `-race` ?

Glide fails to detect VCS even though explicitly specified in glide.yaml

+1 I have the same issue if you can add support for private git repos that would be a huge advantage over `go get`