Deirdre Connolly comments

Results 45 comments of


                                            Deirdre Connolly

build(deps): bump futures from 0.3.21 to 0.3.23

> oh whoops

Type Orchard and Sapling note commitment `x`/`u` coordinates instead of a plain `Base` types

This is still a valid issue 👍

Truncate branch name when used in Google Cloud names

> ## Motivation > Zebra's DevOps workflows fail on long branch names: > > > ERROR: (gcloud.compute.images.create) Could not fetch resource: > > > > * Invalid value for field...

Add support for Orchard proof batch verification

Looking at the changes in https://github.com/zcash/orchard/pull/338/files, we will probably pull in `halo2_proofs::plonk::BatchVerifier` and slot that into our `tower::Service`

NUP: the New NUPenning

> Hmm, this proposal would be putting a lot of power in the hands of the ZIP Editors. > > (Disclosure of interest: @dconnolly and I are the current ZIP...

Handle a ivk == ⊥ (KA^Orchard private key) when generating an Orchard Spending Key

I think this was implemented before this check was added to the spec, and yeah we should handle this before/as we ramp up zebra-client work

Fatal error: write after end

I'm seeing this too, but I'm pretty sure it's not a grunt-karma problem as I see it with just the karma cli runner too. Try karma-runner/karma.

EdwardsPoint::decompress accepts y higher than field modulo

> Issues like this matter primarily for consensus protocols with implementations in other languages. There are other reasons the ed25519-dalek is not ideal for consensus, so the best place maybe...

Communication channels

I would vote in favor of Discord if only because we can also use it as the AV meeting platform for sync discussions as needed (afaik Zulip doesn't have video/audio...

Relay mempool transactions based on the ZIP-317 fee rules

> We want to deploy the new relaying rules in ZIP-317 after most wallets have updated to the new conventional fee. 'The eviction weight is already proportional to the size...