zebra Handle a ivk == ⊥ (KA^Orchard private key) when generating an Orchard Spending Key

Handle a ivk == ⊥ (KA^Orchard private key) when generating an Orchard Spending Key

Open conradoplg opened this issue 2 years ago • 2 comments

Currently, SpendingKey::new does not seem to handle the case where the derived ivk is ⊥, which should trigger retrying with a new key per the spec.

https://zips.z.cash/protocol/protocol.pdf#orchardkeycomponents

Note that this is not urgent (AFAIK) since it's unlikely that ivk will be ⊥ per Theorem 5.4.4, but we should eventually match the spec.

N/A

Jul 14 '21 20:07 conradoplg

I think this was implemented before this check was added to the spec, and yeah we should handle this before/as we ramp up zebra-client work

Jul 14 '21 20:07 dconnolly

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

Nov 03 '21 11:11 mpguerra

Closed by PR #5476 by deleting the spending key code.

Oct 27 '22 22:10 teor2345