Diogo Castro

Results 39 comments of Diogo Castro

> I mean the fact of copy-paste wasn't mentioned in "Cons". That's a good point :/ Would you still say this is worth pursuing, despite the cons? Or do you...

I would also add: * `cyclePred` * `safeSucc :: a -> Maybe a` and `safePred :: a -> Maybe a` Just as `safeToEnum` is useful for when `a` is "narrower"...

> Why not use a bit of CPP? Hmm I guess using CPP to either re-export `hoistMaybe` or define it from scratch would help avoid issues when a user has...

I think this can be merged, right?

> https://www.snoyman.com/blog/2016/12/beware-of-readfile IIUC, the encoding issues described here can be solved by employing the same strategy Kirill Elagin used in the [`with-utf8` package](https://hackage.haskell.org/package/with-utf8) (essentially, use `hSetEncoding utf8` [under the hood](https://github.com/serokell/haskell-with-utf8/blob/e74dcfafbf1889073392ced319acb9336bad6e77/lib/System/IO/Utf8.hs#L157-L163))....

I had a look at `foldMapM` to see how evaluation would look like. If we expand the definition a bit, and add a type sig to `step` for clarity: ```hs...

> Also either deprecate `toLText` or add `toLByteString` or only add `toLByteString` I say we deprecate and eventually delete `toLText`

Let's also: * Delete the re-export of `Data.Text.Lazy.toStrict` and `Data.Text.Lazy.fromStrict` from `Universum.String.Reexport` * Remember to update the rules in `.hlint.yaml`

@be5invis Well, I've updated vscode to 1.13.0 this morning, but it hasn't been working for a couple of days now. This happens with any file, really. I just created a...