universum icon indicating copy to clipboard operation
universum copied to clipboard

Add `universum-prelude`

Open Martoon-00 opened this issue 3 years ago • 2 comments

Description

Add an easy way to implicitly import Universum in other projects.

I'm yet about to test it. Unfortunately, the maintainer of base-noprelude is away for some time already, and base-noprelude is now too outdated to be used in any of our projects, see https://github.com/haskell-hvr/base-noprelude/issues/11.

I didn't update cI workflows, since stack build already covers the new module, and the new package is too small to test it with cabal too.

Related issues(s)

✓ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

  • [x] I made sure my PR addresses a single concern, or multiple concerns which are inextricably linked. Otherwise I should open multiple PR's.
  • [x] If your PR fixes/relates to an open issue then the description should reference this issue. See also auto linking on github.

Related changes (conditional)

  • Tests

    • [x] If I added new functionality, I added tests covering it.
    • [x] If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    I checked whether I should update the docs and did so if necessary:

    • [x] README
    • [x] Haddock
  • Record your changes

    • [x] I added an entry to the changelog if my changes are visible to the users and
    • [x] provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)

  • [x] My commit history is clean (only contains changes relating to my issue/pull request and no reverted-my-earlier-commit changes) and commit messages start with identifiers of related issues in square brackets.

    Example: [#42] Short commit description

    If necessary both of these can be achieved even after the commits have been made/pushed using rebase and squash.

Martoon-00 avatar Aug 09 '21 16:08 Martoon-00

I think this can be merged, right?

dcastro avatar Mar 12 '22 11:03 dcastro

I failed to test the new universum-prelude (I tried in xrefcheck) because base-noprelude was not updated for a while and there is no version that would match the LTS we use. And looks like base-noprelude's maintainer is yet gone, so we are in a quite unpleasant situation for now :crying_cat_face:

Martoon-00 avatar Mar 12 '22 11:03 Martoon-00