Dany Castillo

Results 108 comments of Dany Castillo

To anyone reading, I just found a workaround. The scroll removal is implemented in the `Overlay` component. https://github.com/radix-ui/primitives/blob/6da75e0dbb2d1aebd2dae5a044c595bca39a2347/packages/react/dialog/src/Dialog.tsx#L201-L219 So replacing the `Dialog.Overlay` with a `div` does the trick. Just keep...

Thanks for your explanation! Makes sense that the code ends up like this after being transformed to ESM and back. Hmmm yeah that seems like a tough edge case. I'm...

But then it isn't ordered chronologically anymore. I'd like to treat commits the same as PRs and don't separate them. So the draft looks like this: ```markdown ## What's Changed...

Yes, that sounds good! 👍 But I just realised that commits would need its own template as the `$NUMBER` variable for a PR is likely to be prepended by a...

@IanVS I realized that this error was caused by the [MobX devtools extension](https://chrome.google.com/webstore/detail/mobx-developer-tools/pfgnfdagidkfgccljigdamigbcnndkod). Disabling the extension resolved the issue for me. Forgot to update this issue, sorry for that!

Hey @WesselKroos! 👋 I could reproduce it and indeed the issue is that tailwind-merge includes the `full` value as part of the spacing scale ([code](https://github.com/dcastil/tailwind-merge/blob/v2.2.1/src/lib/default-config.ts#L98)) while Tailwind CSS defines it...

Oh yeah, you're right, the fractions have the same problem. > Do you think it could make sense to use a similar approach here? / Would it be worth to...

Thanks @jzxhuang! I'm also looking for more opportunities to reduce the bundle size. The default config has by far the biggest impact on bundle size (75% of gzipped lib), so...

@yuuk True, I see it as well. Is this causing an issue for you? Note to myself: - Documentation on browserslist behavior in `@babel/preset-env`: https://babeljs.io/docs/babel-preset-env#browserslist-integration - browserslist of Radix: https://github.com/radix-ui/primitives/blob/3e0642e40038386d58da9fb1d812c2fbfe9f67c1/babel.config.js#L30-L31...

@yuuk I added a new issue to add an ES5-compatible build to tailwind-merge: https://github.com/dcastil/tailwind-merge/issues/283 I will probably be able to ship it next weekend or so.