David Buchmann

Results 944 comments of David Buchmann

thank you for the heads up! then i will refrain from merging until you (or somebody else) has been able to check that use case and possibly adjust this PR...

@wouterSkepp do you have time to look into this so we can wrap up the feature?

hi, thanks for the clear report. is the rest of cjpeg between the two libraries compatible (for what imagine is using)? i wonder if we break things for people if...

fantastic for the check-setup command :rocket: if the -quant-table is enabled and calling cjpeg fails, i would continue to throw an exception, but instead of the generic exception it could...

so the mozjpeg patch also adds functionality? does the quant-table option exist in turbo too, but with a different name? are there other features we rely on that are not...

is the prefix you need so dynamic that you can not determine the value when symfony cache is built, and you also can't use a system environment variable? that would...

i don't see the access control in this code. if all you need is storing the source images outside of the web root, you can configure a different data root:...

the github issues are intended to report bugs with the bundle. i am okay to help a bit more than that, but you need to be more specific. at which...

yeah, i agree that a reusable service is best for these kind of things. for the remove command, i am a bit confused as `CacheManager::remove` already accepts null for the...

i guess it makes sense to make them configureable. we should add them to the configuration, like we have it for the class https://github.com/symfony-cmf/BlockBundle/blob/master/DependencyInjection/Configuration.php#L48 and adjust the xml schema accrodingly,...