David Buchmann
David Buchmann
> > Hi, I have some suggestions. I think that in the attributes, the use of "Map" is redundant (MapTo, MapWith, MapIf, etc..). I think you can drop the "Map"...
you mean this? https://github.com/symfony-cmf/BlockBundle/blob/master/Cache/BlockVarnishCache.php#L117 absolutely would make sense to be configurable. you could change the default to `null` and if the value is null use the configured default ttl. you...
i think here is the right place, as its injected in the constructor of the sonata cache class that is created. sonata cache can't provide a default value there, the...
thanks and good luck! please tell if you find something. its pretty busy here, did not have time to look into it myself.
maybe the service that dataCollector service could be made [lazy](http://symfony.com/doc/current/components/dependency_injection/lazy_services.html) to solve the circularity issue?
does the problem also occur with only sonata cache and sonata block, without cmf block? or does sonata do some clever trick with their service that we could mimick?
sorry, i also don't know enough why this starts to happen or what to do without digging deep into it - for which i unfortunately have no time at this...
@rmsint i think you originally added this. can you help us where this comes from? do you have any idea how to break the circle or where to look for...
that could make sense yes. but would need to be done in the sonata bundle, not here, right? you would have to ask rande for sonata, or just propose a...
seems i missed this one as well with my phpunit upgrade, so tests need to be adjusted for phpunit 6. lets discuss things in https://github.com/symfony-cmf/routing-bundle/pull/434#pullrequestreview-197406052 and then update this once...