David Buchmann

Results 944 comments of David Buchmann

i don't want to do that now, just wanted to keep the cleanups that we agreed are useful but are BC break. i don't intend to merge this anytime soon.

as per discussion in #36 i want to merge this soonish. does that change if we want to drop httplug 1 support? the cost of supporting both is low and...

i did not find the time to continue on this. if you want to wrap things up, more than happy to review things ;-)

looks good. i would leave out adapters, that would complicate the diagram quite a bit

cool! could we use coloring (like greying out or such) to separate php-http libraries and 3rd party libraries? and psr 7 could be more highlighted, maybe with a star-box around...

first version with yellow background?

where is that zend adapter? would be cool if we would at least mention it in the framework integration section. maybe we can just reference the doc of that adapter...

similar to what i do in #258

only overwriting router.default and keeping that one available as something else would indeed help. overwriting router is not playing nicely with other bundles.

we are using PSR-7 messages. the MessageInterface says that getBody returns a StreamInterface. https://www.php-fig.org/psr/psr-7/#31-psrhttpmessagemessageinterface the promise is supposed to return a PSR-7 response, so the body is always a stream....