David Buchmann

Results 944 comments of David Buchmann

good point. the classes have been added in #128 and have been `@internal` since the beginning.

the problem with non-final classes is that people will start extending them, and then complain when things break because we change their signature. extending a class can break in so...

i do remember a few cases where people complained when we broke stuff, and i remember tons of cases where we had huge discussions about breaking BC with changes in...

that i don't remember. but what is your goal? would you only soft-mark the classes as internal, and allow people to break the rules and when things break for them,...

from https://github.com/elastic/elasticsearch-php/issues/990: a solution proposed at https://bugs.php.net/bug.php?id=61141#1348321490 is ``` while ($active && $mrc == CURLM_OK) { if (curl_multi_select($mh) == -1) usleep(100); do { $mrc = curl_multi_exec($mh, $active); } while ($mrc...

interesting, seems its not even that hard to build basic node type definitions. i think the logic to build cnd from metadata should go into a service. configured with a...

should this go into phpcr-odm rather than the bundle?

i like the idea. if you have time to work on it, please do. for the doctrinedbal dsn, we should use the dbal connection name as "domain" i think. it...

yes, please squash the commits into one and then rebase on master (we touched the .travis.yml and composer.json, there will be some conflicts)

@Soullivaneuh are you familiar with the ORM EntityType? would you maybe have time to look at this pull request and see if you have an idea how to need less...