Daniël Brekelmans

Results 17 comments of Daniël Brekelmans

I'm also running into this issue. Code is compatible with 7.1, but box is detecting a 7.2 requirement somehow. https://github.com/dbrekelmans/release-action-test-source/runs/1545723577?check_suite_focus=true

Hi @fox91, following your PR with submodules (https://github.com/thecodingmachine/safe/pull/292), I'm targeting the `1.x` branch, but for some reason the github actions are detecting changes in the generated files. I'm not sure...

@Kharhamel PR #292 introduced git submodules for the doc files, pinned to a certain commit hash. So in theory, everyone should get the exact same docs (that specific commit hash)

Yeah, makes sense to me! Looking forward to the PR :) Keep in mind that this change should be done in the generator, not in the individual generated files.

Hey @fox91, thanks for creating the issue. We're working on a PHP8 compatible release. We haven't yet had the time to figure out how to support multiple different PHP versions,...

Hi @iquito. This seems like a big change and BC-break for a slight performance increase. Do you have any objective numbers of performance improvement? From the comments of #253, it...

@Aerendir This would be fixed by https://github.com/thecodingmachine/safe/pull/372, correct?

Agreed. I would be in favor of doing a new patch release after this is merged.

Hi, I'm looking into > Change C) Investigate removing ComponentInterface and LiveComponentInterface in favor of annotations/attributes. Currently looking at TwigComponent first. I think we could support three different options of...

@d-gubert I can confirm that the files in the zip are identical to the source files. Yes, I have this docker image so I don't have to install node and...