safe icon indicating copy to clipboard operation
safe copied to clipboard

Published 20 hours ago • verified publisher icon thecodingmachine

Take into account global error handlers

Open j3j5 opened this issue 2 years ago • 1 comments

Hi there,

I was reading this thread on Twitter by Christian Lück and I immediately thought on Safe.

I just checked and just like on his example, this library uses error_get_last() without accounting for any other global error handlers set by the application. I checked fopen() but I guess the implementation is the same for all functions using error_get_last().

What do you think? Shall this be addressed? Would you like a MR?

j3j5 avatar Mar 15 '22 20:03 j3j5

Yeah, makes sense to me! Looking forward to the PR :)

Keep in mind that this change should be done in the generator, not in the individual generated files.

dbrekelmans avatar Mar 17 '22 08:03 dbrekelmans