Dag Brattli comments

Results 190 comments of


                                            Dag Brattli

chore(deps): update dependency fantomas to 7.0.2

:unicorn:

Avoid use of asyncio.get_event_loop (3.14)

@traylenator Please try to rebase now. The build should be fixed again.

Avoid use of asyncio.get_event_loop (3.14)

I think we need to consider deprecating Pythobn 3.8 as well. I see it's giving problems for this PR. I'll have a look at it this weekend.

[WIP] Documentation Refactor

I'm in favor of better documentation 🥰 However, there are some things about this PR that worries me: 1. Having JS specific examples will be confusing and feel wrong for...

python: anonymous record creation generates camel case dict fields

For Python code should be for formatted and styled according to [PEP-8](https://peps.python.org/pep-0008/#naming-conventions). This means that only types are CapitalizedWords, and almost anything else is lower_case_with_underscores. This is important for Python...

python: anonymous record creation generates camel case dict fields

Yes, I for anonymous records I agree that we should not do any conversion of the names. Both this and the KeyError is easy to fix. For Records I'm still...

python: anonymous record creation generates camel case dict fields

One problem I see with any translation of field names for Records is reflection info. It's quite hard to generate code that preserves .NET semantics in Python and we easily...

python: anonymous record creation generates camel case dict fields

Aha, of course, that would solve the problem. Thank you so much for unblocking me on this one @MangelMaxime 😊 The other crux I ran into btw was type testing...

python: passing function reference introduces unnecessary closure

Hey, thanks for the issue. This is unfortunately not that easy to fix. The Python version is actually doing the same thing as the JS version. The JS version also...

Alias `choose` on `Seq` as `flatMap` (or `flat_map` or `flatmap`)

Hi. The operator you are looking for is called `collect`.