Dag Brattli comments

Results 190 comments of


                                            Dag Brattli

Introduced Observable >> operator as pipe shorthand

This becomes too much "magic" imo. 1. This is not the way things are normally done in Python 2. The operator `>>` means compose in F#, not pipe 3. Using...

Introduced Observable >> operator as pipe shorthand

Yes, I have been thinking about a pipe operator myself for some time. The F# pipe operator however have some problems with Python since we don't have currying and writing...

Python 3.12 deprecates timezone non aware utcfromtimestamp() and utcnow()

This is now fixed

Question: Is there a reason why pipeline is buried so far into the package? from expression.extra.result import pipeline

Hi, it was added there since I was unsure if it should be added as it is in the current form (or not) i.e naming. But I guess we could...

Question: How do you use @effect.result with asyncio?

For this to work we would need a separate `effect.async_result`.

Add `NonEmptyBlock` class and utility functions

Looks very nice. Could we perhaps subclass Block to avoid so much code duplication? E.g by using the new `Self` type in `block.py` so functions return `NonEmptyBlock` instead of `Block`?

[Python] '<' not supported between instances of 'dict' and 'dict'

I cannot reproduce so it would be great with a minimal repro. I also cannot make that example fail @MangelMaxime. Does it fail on your machine? This might be related...

Fix map's change (issue 105)

Hi @matiboy. I didn't see your PR before I fixed the `change` bug. But it looks like you have found another bug as well. Anyways, I would like to keep...

Fix 4041

The description of this PR is empty. Please add Why and How. Links are good, but the PR should explain exactly what is being done and why.

Fix 4041

@klofberg Since you are changing `FSharp2Fable.Utils.fs` this PR affects all targets. The code generation for Python looks worse after this fix, so I don't think I would like to have...