Daniel (dB.) Doubrovkine
Daniel (dB.) Doubrovkine
Same comment as https://github.com/opensearch-project/OpenSearch/pull/15360#issuecomment-2307561923 please.
I think that handling 404s from the router _should_ be something that Grape provides. Maybe something like `rescue_from :404`? Please suggest.
@staii That sounds reasonable. Try making a PR.
I really don't know the best place, but either way the stacking of the midleware in Grape is probably something that should be refactored. Maybe there's a cleaner way to...
[Catch All Triage - [1](https://github.com/dblock), [2](https://github.com/krisfreedain), [3](https://github.com/amistrn)]
@songkant-aws reach out to the folks in MAINTAINERS.md?
[Catch All Triage, attendees [1](https://github.com/dblock), [2](https://github.com/reta), [3](https://github.com/lukas-vlcek/), [4](https://github.com/rafaelma), [5](https://github.com/krisfreedain), [6](https://github.com/gargrajat), [7](https://github.com/andrross)] Thanks for opening this, do you have repro steps for it?
[[Catch All Triage](https://github.com/opensearch-project/.github/blob/main/TRIAGING.md) - [1](https://github.com/dblock), [2](https://github.com/reta), [3](https://github.com/andrross/)]
Please don't forget https://github.com/opensearch-project/opensearch-api-specification. See https://github.com/opensearch-project/opensearch-api-specification/pull/611 for recent changes in that space.
> @dblock I don't think slowing things down would have been the intention. I meant that below the code does `aggregations[index][ord]`. This could have been the beginning of an optimization...